120: "repo_import_latest&id=all" does not work

(128)
John Reese (administrator)
2010-03-26 13:45

Fix committed to master branch at 2010-03-26 20:37:11.

(133)
Lars (reporter)
2010-03-29 03:56

I copied the file
repo_import_latest.php
from your repository into my mantis (not more not less).
But the same error occures.

Do I have to do more?

LArs

(134)
Philipp Beckmann (reporter)
2010-03-29 05:37

Have you added your IP or Hostname to the "Allowed Addresses" for "Remote Import"?

(135)
Lars (reporter)
2010-03-29 06:03

hi Philipp,
thanks for the tip.

Our server names changed last week and I changed the hostname inside the source control config.

But again a fault:

APPLICATION ERROR 203
A number was expected for id.

Lars

(136)
Philipp Beckmann (reporter)
2010-03-29 07:34

Hi Lars,

this looks like you're still using an old version of repo_import_latest.php.
Error 203 is thrown by gpc_get_int, which was replaced by gpc_get_string when adding the "id=all" exception.

Philipp

(137)
Lars (reporter)
2010-03-29 07:50

He Philipp,
sorry, but I checked the file. It's the new one. I see the new code inside it.

It's also crazy, that I see another error, if I call the command via curl:

curl plugin.php?page=Source/repo_import_latest&id=all [^]

APPLICATION ERROR 200
a required parameter to this page (id) was not found ...

Lars

(138)
Philipp Beckmann (reporter)
2010-03-29 07:54

You need to quote the URL

(139)
Lars (reporter)
2010-03-29 07:58

sure - shit

but, why works now for curl and not via browser?

but not the urgent problem ...

if the cron job works, its fine ...

sorry for my questions

LArs

(140)
John Reese (administrator)
2010-03-29 08:05

It should be working correctly from a browser, as well, assuming you are logged in and your user account has appropriate access to manage the repository. If you are still getting error 203, I'm not sure what could be causing that; as Philipp mentioned, the new code should no longer be checking for an int. Perhaps if you could get a stack trace of the error by setting `$g_show_detailed_errors = ON;` in your config_inc.php, that would help track down the problem?

(143)
Lars (reporter)
2010-03-30 02:55
edited on: 2010-03-30 06:09

ok,
error 1 (see attached file ...error1) is from my windows pc - called from mantis, latest release, latest Source integration files,
I go to repositories, manage one of them, import latest data, changed the ID to "all" ...

-----------------

but it works for each ID on browser!
since begin of SourceControl Integration ... only the new "all" doeas not work ...

(144)
Philipp Beckmann (reporter)
2010-03-30 04:55

This is because the script always tries to load the next unknown revision ( = max(known_revision)+1) ). But if there is no newer revision since last import, svn complains.

With cron, this spectacle occurs every X minutes, with exception of the repos where a checkin happened recently.

(154)
Lars (reporter)
2010-04-07 05:48

so ok,
with cron job it works ... but still a problem with browser.
perhaps you'll have a look at the attached file ...

for me it's ok now.

(179)
John Reese (administrator)
2010-04-12 10:42

Just as an FYI: recent commits have changed the way this new feature works. Remote imports now use a separate page ("import"), and still supports id=all. The existing page "repo_import_latest" has been updated to require an authenticated user session, and no longer supports id=all as there is no UI method of getting to that point.

Marking this issue as resolved.

Related Changesets
Source Integration: master 72641b0b Timestamp: 2010-03-26 20:37:11 Author: John Reese Committer: John Reese [ Details ] [ Diff ]	Fix 120: Only check auth if not valid remote
	mod - Source/pages/repo_import_latest.php	[ Diff ] [ File ]

Notes
(128) John Reese (administrator) 2010-03-26 13:45	Fix committed to master branch at 2010-03-26 20:37:11.

(133) Lars (reporter) 2010-03-29 03:56	I copied the file repo_import_latest.php from your repository into my mantis (not more not less). But the same error occures. Do I have to do more? LArs

(134) Philipp Beckmann (reporter) 2010-03-29 05:37	Have you added your IP or Hostname to the "Allowed Addresses" for "Remote Import"?

(135) Lars (reporter) 2010-03-29 06:03	hi Philipp, thanks for the tip. Our server names changed last week and I changed the hostname inside the source control config. But again a fault: APPLICATION ERROR 203 A number was expected for id. Lars

(136) Philipp Beckmann (reporter) 2010-03-29 07:34	Hi Lars, this looks like you're still using an old version of repo_import_latest.php. Error 203 is thrown by gpc_get_int, which was replaced by gpc_get_string when adding the "id=all" exception. Philipp

(137) Lars (reporter) 2010-03-29 07:50	He Philipp, sorry, but I checked the file. It's the new one. I see the new code inside it. It's also crazy, that I see another error, if I call the command via curl: curl plugin.php?page=Source/repo_import_latest&id=all [^] APPLICATION ERROR 200 a required parameter to this page (id) was not found ... Lars

(138) Philipp Beckmann (reporter) 2010-03-29 07:54	You need to quote the URL

(139) Lars (reporter) 2010-03-29 07:58	sure - shit but, why works now for curl and not via browser? but not the urgent problem ... if the cron job works, its fine ... sorry for my questions LArs

(140) John Reese (administrator) 2010-03-29 08:05	It should be working correctly from a browser, as well, assuming you are logged in and your user account has appropriate access to manage the repository. If you are still getting error 203, I'm not sure what could be causing that; as Philipp mentioned, the new code should no longer be checking for an int. Perhaps if you could get a stack trace of the error by setting `$g_show_detailed_errors = ON;` in your config_inc.php, that would help track down the problem?

(143) Lars (reporter) 2010-03-30 02:55 edited on: 2010-03-30 06:09	ok, error 1 (see attached file ...error1) is from my windows pc - called from mantis, latest release, latest Source integration files, I go to repositories, manage one of them, import latest data, changed the ID to "all" ... ----------------- but it works for each ID on browser! since begin of SourceControl Integration ... only the new "all" doeas not work ...

(144) Philipp Beckmann (reporter) 2010-03-30 04:55	This is because the script always tries to load the next unknown revision ( = max(known_revision)+1) ). But if there is no newer revision since last import, svn complains. With cron, this spectacle occurs every X minutes, with exception of the repos where a checkin happened recently.

(154) Lars (reporter) 2010-04-07 05:48	so ok, with cron job it works ... but still a problem with browser. perhaps you'll have a look at the attached file ... for me it's ok now.

(179) John Reese (administrator) 2010-04-12 10:42	Just as an FYI: recent commits have changed the way this new feature works. Remote imports now use a separate page ("import"), and still supports id=all. The existing page "repo_import_latest" has been updated to require an authenticated user session, and no longer supports id=all as there is no UI method of getting to that point. Marking this issue as resolved.

Issue History
Date Modified	Username	Field	Change
2010-03-24 03:32	Lars	New Issue
2010-03-26 13:45	John Reese	Note Added: 128
2010-03-26 13:45	John Reese	Status	new => resolved
2010-03-26 13:45	John Reese	Fixed in Version	=> 0.16
2010-03-26 13:45	John Reese	Resolution	open => fixed
2010-03-26 13:45	John Reese	Assigned To	=> John Reese
2010-03-26 13:45	John Reese	Changeset attached	master 72641b0b =>
2010-03-29 03:56	Lars	Note Added: 133
2010-03-29 03:56	Lars	Status	resolved => feedback
2010-03-29 03:56	Lars	Resolution	fixed => reopened
2010-03-29 05:37	Philipp Beckmann	Note Added: 134
2010-03-29 06:03	Lars	Note Added: 135
2010-03-29 06:03	Lars	Status	feedback => assigned
2010-03-29 07:34	Philipp Beckmann	Note Added: 136
2010-03-29 07:50	Lars	Note Added: 137
2010-03-29 07:54	Philipp Beckmann	Note Added: 138
2010-03-29 07:58	Lars	Note Added: 139
2010-03-29 08:05	John Reese	Note Added: 140
2010-03-30 02:53	Lars	File Added: mantis_source_control_error1.mht
2010-03-30 02:55	Lars	Note Added: 143
2010-03-30 04:15	Lars	Note Edited: 143	View Revisions
2010-03-30 04:55	Philipp Beckmann	Note Added: 144
2010-03-30 06:09	Lars	Note Edited: 143	View Revisions
2010-04-07 05:48	Lars	Note Added: 154
2010-04-12 10:42	John Reese	Note Added: 179
2010-04-12 10:42	John Reese	Status	assigned => resolved
2010-04-12 10:42	John Reese	Fixed in Version	0.16 =>
2010-04-12 10:42	John Reese	Resolution	reopened => unable to reproduce

Relationships