179: Diff and File links are alwys shown.

Notice: this is a static mirror for historical purposes.

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

179

Source Integration

WebSVN

public

2010-10-08 05:22

2011-01-18 02:05

Reporter

Tobias Schlauch

Assigned To

Priority

normal

Severity

major

Reproducibility

always

Status

new

Resolution

open

Product Version

Target Version

Fixed in Version

Summary

179: Diff and File links are alwys shown.

Description

You are checking for instance for files that are deleted within a change set the following way:

if ( $p_file->action == 'D' ) {
return '';
}

But within the action property not 'D' is used but 'rm'. Similar things happen in case of:
'A' -> add
'M' -> 'mod'
'R' -> 'mv'

This problem also exists with the WebSVN plugin. So this issue is related to 174. I attached a patch which should resolve the problem.

I also extended the condition to prevent link display in case of moved items.

Tags

No tags attached.

Attached Files

Relationships

Notes
(260) obones (reporter) 2011-01-18 02:05	The patch works just fine for me

Issue History
Date Modified	Username	Field	Change
2010-10-08 05:22	Tobias Schlauch	New Issue
2010-10-08 05:22	Tobias Schlauch	File Added: diff_file_link.patch
2011-01-18 02:05	obones	Note Added: 260

Time: 0.1173 seconds.
memory usage: 8,361 KB

hosted with