Notice: this is a static mirror for historical purposes.

View Issue Details Jump to Notes ] Related Changesets ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
099Source Integration[All Projects] Generalpublic2010-02-17 05:532010-02-23 11:00
ReporterJames Keir 
Assigned ToJohn Reese 
PriorityhighSeveritymajorReproducibilityalways
StatusresolvedResolutionfixed 
Product Version0.13 
Target VersionFixed in Version0.16 
Summary099: SVN import crashes when --non-interactive flag is use
DescriptionWhen trying to do any SVN import with the --non-interactive flag the import crashes. When I comment out the --non-interactive flag it works no problem. I did some investigation and when you are testing the command with "/usr/bin/svn --non-interactive help" it is failing where it should be "/usr/bin/svn help"
TagsNo tags attached.
Attached Files

- Relationships
has duplicate 107resolvedJohn Reese Bug in SourceSVNPlugin function check_svn: help does not accept non-interactive parameter 

-  Notes
User avatar (093)
James Keir (reporter)
2010-02-17 05:58
edited on: 2010-02-17 06:00

I fixed this issue by changing the following in "SourceSVN/SourceSVN.php" from:
        private function check_svn() {
                $svn = $this->svn_call();

                if ( is_blank( shell_exec( "$svn help" ) ) ) {
                        trigger_error( ERROR_GENERIC, ERROR);
                }
        }

To this:

        private function check_svn() {
                if ( is_blank( shell_exec( self::svn_binary() . " help" ) ) ) {
                        trigger_error( ERROR_GENERIC, ERROR);
                }
        }

User avatar (100)
John Reese (administrator)
2010-02-21 17:40

Hmm, I can't reproduce the problem on my own machine:

jreese@mach[~] svn --non-interactive help
usage: svn <subcommand> [options] [args]
Subversion command-line client, version 1.6.5.
...


What version of SVN are you using? Perhaps the problem only occurs on older versions? If so, I can modify the plugins to use the flag only in the appropriate contexts.
User avatar (102)
James Keir (reporter)
2010-02-22 05:45

I'm using Suversion 1.4.2 on CentOS. The problem might be in PHP as I think it detects it as an errored call (svn --non-interactive help) and returns null. Once I did the correct call (svn help) I got the expected responce. I'm running PHP 5.3.1 with Apache 1.3.41.
User avatar (104)
Jan (reporter)
2010-02-23 09:48

I can confirm the error in Subversion 1.4.2 on Debian.
User avatar (106)
John Reese (administrator)
2010-02-23 11:00

Fix committed to master branch at 2010-02-23 18:57:55.

- Related Changesets
Source Integration: master ff8a1696
Timestamp: 2010-02-23 18:57:55
Author: John Reese
Committer: John Reese
Details ] Diff ]
Fix 099: Use svn_binary in svn_check
mod - SourceSVN/SourceSVN.php Diff ] File ]

- Issue History
Date Modified Username Field Change
2010-02-17 05:53 James Keir New Issue
2010-02-17 05:58 James Keir Note Added: 093
2010-02-17 05:59 James Keir Note Added: 094
2010-02-17 05:59 James Keir Note Deleted: 094
2010-02-17 06:00 James Keir Note Edited: 093 View Revisions
2010-02-21 17:40 John Reese Note Added: 100
2010-02-21 17:40 John Reese Assigned To => John Reese
2010-02-21 17:40 John Reese Status new => feedback
2010-02-22 05:45 James Keir Note Added: 102
2010-02-22 05:45 James Keir Status feedback => assigned
2010-02-23 09:48 Jan Note Added: 104
2010-02-23 10:51 John Reese Relationship added has duplicate 107
2010-02-23 11:00 John Reese Note Added: 106
2010-02-23 11:00 John Reese Status assigned => resolved
2010-02-23 11:00 John Reese Fixed in Version => 0.16
2010-02-23 11:00 John Reese Resolution open => fixed
2010-02-23 11:00 John Reese Changeset attached master ff8a1696 =>


Copyright © 2000 - 2012 MantisBT Group
Time: 0.1634 seconds.
memory usage: 8,399 KB
Powered by Mantis Bugtracker

hosted with
Linode