131: History is reversed when adding a change set

Notice: this is a static mirror for historical purposes.

View Issue Details [ Jump to Notes ] [ Related Changesets ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

131

Source Integration

[All Projects] General

public

2010-04-08 05:31

2010-04-19 13:45

Reporter

obones

Assigned To

John Reese

Priority

normal

Severity

minor

Reproducibility

always

Status

resolved

Resolution

fixed

Product Version

0.16

Target Version

0.16

Fixed in Version

0.16

Summary

131: History is reversed when adding a change set

Description

When adding a change set, the "new value" is empty while the old value contains the newly added changeset number.
This gives history like this:

08-04-2010 14:22 Olivier SANNIER Source_changeset_attached trunk r28460 =>

where one would expect this:

08-04-2010 14:25 Olivier SANNIER Source_changeset_attached => trunk r28460

This is because the order of parameters when calling plugin_history_log is bogus for the "add bug" case at line 942 inside Source.API.php

Exchanging parameters 2 and 3 fixes this, thus giving the following source code:

plugin_history_log( $t_bug_id, 'changeset_attached',
    '',
    $t_vcs->show_changeset( $this->repo, $this ),
    $t_user_id, 'Source' );

Steps To Reproduce

Add a new changeset to an issue
Look at the issue history

Tags

No tags attached.

Attached Files

Relationships

Notes
(201) John Reese (administrator) 2010-04-19 13:25	This is a result of an upstream change in MantisBT shortly before the 1.2 release, where the behavior of history entries was changed, and I never noticed. =\

(202) John Reese (administrator) 2010-04-19 13:45	Fix committed to master branch at 2010-04-19 20:31:29.

Related Changesets
Source Integration: master 37d3575c Timestamp: 2010-04-19 20:31:29 Author: John Reese Committer: John Reese [ Details ] [ Diff ]	Fix 131: Reversed history entry
	mod - Source/Source.API.php	[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2010-04-08 05:31	obones	New Issue
2010-04-19 13:25	John Reese	Note Added: 201
2010-04-19 13:25	John Reese	Assigned To	=> John Reese
2010-04-19 13:25	John Reese	Severity	major => minor
2010-04-19 13:25	John Reese	Status	new => assigned
2010-04-19 13:25	John Reese	Product Version	=> 0.16
2010-04-19 13:25	John Reese	Target Version	=> 0.16
2010-04-19 13:45	John Reese	Note Added: 202
2010-04-19 13:45	John Reese	Status	assigned => resolved
2010-04-19 13:45	John Reese	Fixed in Version	=> 0.16
2010-04-19 13:45	John Reese	Resolution	open => fixed
2010-04-19 13:45	John Reese	Changeset attached	Source Integration master 37d3575c =>

Time: 0.1448 seconds.
memory usage: 8,349 KB

hosted with