138: Latest version still uses plugin_lang_get("version")

Notice: this is a static mirror for historical purposes.

View Issue Details [ Jump to Notes ] [ Related Changesets ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

138

Mantis Plugins

Snippets

public

2010-04-16 00:57

2010-04-16 06:45

Reporter

obones

Assigned To

John Reese

Priority

normal

Severity

crash

Reproducibility

always

Status

resolved

Resolution

fixed

Product Version

Target Version

Fixed in Version

Summary

138: Latest version still uses plugin_lang_get("version")

Description

Hello,

The latest source version has the "version" string removed from the translation file which is good.
However, the code still uses plugin_lang_get("version") in one place, inside the xmlhttprequest_plugin_snippets when it fills the data array.
I fixed this by replacing the incriminated line with this one:

"snippets" => $g_plugin_cache[plugin_get_current()]->version,

This obviously only works if the $g_plugin_cache global variable is pushed into the function with this line:

global $g_plugin_cache;

Hope this helps

Tags

No tags attached.

Attached Files

Relationships

Notes
(188) obones (reporter) 2010-04-16 01:24	Attached patch fixes this

(190) John Reese (administrator) 2010-04-16 06:45	Fix committed to master branch at 2010-04-16 13:28:44.

Related Changesets
Snippets: master 1dd3cedf Timestamp: 2010-04-16 13:28:44 Author: John Reese Committer: John Reese [ Details ] [ Diff ]	Fix 138: Lingering usage of version from lang
	mod - Snippets/Snippets.API.php	[ Diff ] [ File ]
	mod - Snippets/Snippets.php	[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2010-04-16 00:57	obones	New Issue
2010-04-16 01:24	obones	File Added: Snippets.API.php.diff
2010-04-16 01:24	obones	Note Added: 188
2010-04-16 06:45	John Reese	Note Added: 190
2010-04-16 06:45	John Reese	Status	new => resolved
2010-04-16 06:45	John Reese	Resolution	open => fixed
2010-04-16 06:45	John Reese	Assigned To	=> John Reese
2010-04-16 06:45	John Reese	Changeset attached	master 1dd3cedf =>

Time: 0.1436 seconds.
memory usage: 8,316 KB

hosted with