146: filename parsing breaks when filename contains parentheses

Notice: this is a static mirror for historical purposes.

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

146

Source Integration

[All Projects] General

public

2010-05-06 06:57

Reporter

Johnnie G.

Assigned To

Priority

normal

Severity

minor

Reproducibility

always

Status

new

Resolution

open

Product Version

0.13

Target Version

Fixed in Version

Summary

146: filename parsing breaks when filename contains parentheses

Description

The regexp that parses the svn log, trying to get the filename, breaks when it contains a '(' character

Steps To Reproduce

commit a change for a file with parentheses in it's name.
i.e. /trunk/myrepo/name(with parenthesis).txt

The check mantis for the actual commit written to the DB.
it will be "/trunk/myrepo/name"

Additional Information

I have implemented a fix that replaces the code in
SourceSVN.php: function process_svn_log

<...snip...>
//addition start
# Handle files with parentheses in their names without matching to the whole string
$t_match_pos = strpos($t_line, ' (from ');
if ($t_match_pos!==FALSE) $t_line = substr($t_line,0,$t_match_pos);
if ( preg_match( '/^\s+([a-zA-Z])\s+(.+)/', $t_line, $t_matches ) ) {
//addition end
  switch( $t_matches[1] ) {
        case 'A': $t_action = 'add'; break;
        case 'D': $t_action = 'rm'; break;
<...snip...>

Issue History
Date Modified	Username	Field	Change
2010-05-06 06:57	Johnnie G.	New Issue

Relationships

Notes
There are no notes attached to this issue.