163: problems with empty SVN revisions

Notice: this is a static mirror for historical purposes.

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

163

Source Integration

WebSVN

public

2010-06-17 08:01

2010-06-18 02:32

Reporter

Karl Reichert

Assigned To

Priority

high

Severity

block

Reproducibility

always

Status

new

Resolution

open

Product Version

0.13

Target Version

Fixed in Version

Summary

163: problems with empty SVN revisions

Description

My server is running Windows XP with Mantis 1.2.1 and Source plugin (VCS Basisintegration 0.16.1 with Subversion Integration 0.16).

I tried to get my SVN repo into Mantis, but the plugin always fetches only a few revisions, not all.

The reason is, that on my company's SVN server, there are "empty" revisions. Please see screenshot attached. I don't know if this is a normal behavoir or a bad configuration of the SVN server, but it's the case.

To get it working, I had to change file SourceSVN.php, function process_svn_log(), line 368, to this:

# Changeset info
} elseif ( 1 == $t_state ) {
    if( preg_match( '/^r([0-9]+) \| ([^|]+) \| ([0-9\-]+) ([0-9:]+)/', $t_line, $t_matches ) ) {
        if ( !is_null( $t_changeset ) ) {
            if ( !is_blank( $t_changeset->branch ) ) {
                $t_changeset->save();
                $t_changesets[] = $t_changeset;
            } else {
                $t_discarded = $t_changeset->revision;
            }
        }

        $t_changeset = new SourceChangeset( $p_repo->id, $t_matches[1], '', $t_matches[3] . ' ' . $t_matches[4], $t_matches[2], '' );
            $t_state = 2;
    } else {
        $t_state = 1;
    }

If an empty version is detected, just the next revision is fetched.

Please add this modification to your development trunk, so if I update the plugin in the future, my modification will not be lost.

As far as I can see, this modification does not effect any "normal" configured SVN server, which does not have empty revisions.

Tags

No tags attached.

Attached Files

Relationships

Notes
(225) Karl Reichert (reporter) 2010-06-18 02:32	I talked with our IT guys, they told me, this behavoir is due to a bug in the pretty old SVN server version our company is using. So this is not the standard behavoir of a SVN server. Nevertheless, I think that you should add the modification anyway. It does not make any changes for "normal" SVN servers, but helps dealing with quirky ones.

Issue History
Date Modified	Username	Field	Change
2010-06-17 08:01	Karl Reichert	New Issue
2010-06-17 08:03	Karl Reichert	File Added: screenshot.png
2010-06-18 02:32	Karl Reichert	Note Added: 225

Time: 0.1334 seconds.
memory usage: 8,320 KB

hosted with