174: Links showing difference between files or file display are always shown.

Notice: this is a static mirror for historical purposes.

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

174

Source Integration

SFSVN

public

2010-09-28 01:20

Reporter

Tobias Schlauch

Assigned To

Priority

normal

Severity

major

Reproducibility

have not tried

Status

new

Resolution

open

Product Version

0.13

Target Version

Fixed in Version

Summary

174: Links showing difference between files or file display are always shown.

Description

You are checking for instance for files that are deleted within a change set the following way:

if ( $p_file->action == 'D' ) {
return '';
}

But within the action property not 'D' is used but 'rm'. Similar things happen in case of:
'A' -> add
'M' -> 'mod'
'R' -> 'mv'

This conversion is done in the SourceSVN.php private function process_svn_log.

Therefore the links are always shown and cause erros in the used web application used to display differences etc.

This also concerns the SourceForge plugin.

Issue History
Date Modified	Username	Field	Change
2010-09-28 01:20	Tobias Schlauch	New Issue

Relationships

Notes
There are no notes attached to this issue.