178: Change changeset diff link to do "Compare with Previous" - LeetCode.net

Notice: this is a static mirror for historical purposes.

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

ID

Project

Category

View Status

Date Submitted

Last Update

178

Source Integration

WebSVN

public

2010-10-06 14:47

2011-01-18 02:10

Reporter

Harvey Chapman

Assigned To

Priority

normal

Severity

feature

Reproducibility

always

Status

new

Resolution

open

Product Version

0.13

Target Version

Fixed in Version

Summary

178: Change changeset diff link to do "Compare with Previous"

Description

Currently, a [diff] link for changeset 100 for "REPO" will look like this:
http://bt/websvn/listing.php?repname=REPO&rev=100&sc=1 [^]

It would be more useful if it were this:
http://bt/websvn/comp.php?repname=REPO&compare[]=%2F@99&compare[]=%2F@100 [^]

This is what happens if you go to the first link and then choose "Compare with previous".

I've attached a patch that makes this change. I think it's correct, but I'm a little unsure about the t_path code.

Tags

No tags attached.

Relationships

Notes
(244) Harvey Chapman (reporter) 2010-10-07 12:17	Fixed bug in first patch. I didn't understand that PHP treats "" and '' the same as shell does when expanding variables included within quotes.

(261) obones (reporter) 2011-01-18 02:10	This patch works just fine, apart from the fact that the double quotes around $t_rev_prev$t_rev are pretty much useless and could be replaced by this: $t_rev_prev.$t_rev It would make the parsing and execution faster.

Issue History
Date Modified	Username	Field	Change
2010-10-06 14:47	Harvey Chapman	New Issue
2010-10-06 14:47	Harvey Chapman	File Added: WebSVN_changeset_diff.patch
2010-10-07 12:16	Harvey Chapman	File Added: WebSVN_changeset_diff_v2.patch
2010-10-07 12:17	Harvey Chapman	Note Added: 244
2011-01-18 02:10	obones	Note Added: 261

Copyright © 2000 - 2012 MantisBT Group

Time: 0.1282 seconds.
memory usage: 8,323 KB

Linode