180: Full Import can change Repository Name to "Import Timestamp"

Notice: this is a static mirror for historical purposes.

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

180

Source Integration

[All Projects] General

public

2010-10-11 05:33

2011-07-21 10:47

Reporter

Roland Shaw

Assigned To

Priority

normal

Severity

minor

Reproducibility

always

Status

new

Resolution

open

Product Version

Target Version

Fixed in Version

Summary

180: Full Import can change Repository Name to "Import Timestamp"

Description

We have some (SVN-)repositories, which loose their names by doing a full import. When starting a full import, $t_repo->name is set to "Import " with the Timestamp :
Source/pages/repo_full_import.php:

$t_new_repo->name = 'Import ' . date( 'Y-m-d H:i:s' );

In the following while-block the name is only restored, if the last importsegment contains almost one element, otherwhise the block will be terminated by "break" without restoring the name.

A simple reordering can fix this (see "additional information").

Additional Information

Path/Fix:

@@ -30,6 +31,9 @@
     # import the next batch of changesets
     $t_changesets = $t_vcs->import_full( $t_new_repo );
 
+	# fix for loosing the repo name
+    $t_new_repo->name = $t_repo->name;
+
     # check for errors
     if ( !is_array( $t_changesets ) ) {
         $t_error = true;
@@ -41,7 +45,6 @@
         break;
     }
 
-	$t_new_repo->name = $t_repo->name;
     Source_Process_Changesets( $t_changesets, $t_new_repo );
 }

Tags

No tags attached.

Attached Files

Relationships

Notes
(258) obones (reporter) 2011-01-18 01:00	Thanks for this, it does fix that issue that I was having as well

(300) John Reese (administrator) 2011-07-21 10:47	A "full import" is badly named, as it actually creates a new repo named with a placeholder, does an import, and then if it succeeds, it deletes the old repo data and renames the new one to match what the old one was named. Unless you specifically want to drop all your existing imported data, using "import latest" will do what you want/need it to do without creating multiple repos.

Issue History
Date Modified	Username	Field	Change
2010-10-11 05:33	Roland Shaw	New Issue
2011-01-18 01:00	obones	Note Added: 258
2011-07-21 10:47	John Reese	Note Added: 300

Time: 0.1188 seconds.
memory usage: 8,322 KB

hosted with