193: websvn "subpath" repositories (standard svn layout) yields bad File and Diff URLs in Related Changesets

Notice: this is a static mirror for historical purposes.

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

193

Source Integration

WebSVN

public

2011-01-31 10:12

Reporter

rolf

Assigned To

Priority

normal

Severity

major

Reproducibility

have not tried

Status

new

Resolution

open

Product Version

Target Version

Fixed in Version

Summary

193: websvn "subpath" repositories (standard svn layout) yields bad File and Diff URLs in Related Changesets

Description

Hi,

The integration between (web)svn and mantis is great. I am just running into a small issue where erroneous URLs are generated when a standard, recommended svn repo layout is used.

* Our standard svn repo layout:

    Repository - project1 - trunk
                                - branches
                                - tags
                  - project2 - trunk
                                - branches
                                - tags
                  - project3 - trunk
                                - branches
                                - tags

* Relevant config from websvn config.php:

    // $config->addRepositorySubpath('NameToDisplay', 'URL to repository (e.g. file:///c:/svn/proj [^])', 'subpath');
    $config->addRepositorySubpath('PROJECT1', 'file:///var/www/svn/repos','project1' [^]);
    $config->addRepositorySubpath('PROJECT2', 'file:///var/www/svn/repos','project2' [^]);
    $config->addRepositorySubpath('PROJECT3', 'file:///var/www/svn/repos','project3' [^]);

* The websvn repository config in Mantis (project1):

    Name project1
    Type WebSVN
    URL file://localhost/var/www/svn/repos/project1 [^]
    Extra Info

    websvn_url => string(25) "https://localhost/websvn/" [^]
    websvn_name => string(8) "PROJECT1"
    websvn_path => string(0) ""
    svn_username => string(9) "mantissvn"
    svn_password => string(8) "********"
    standard_repo => bool(true)
    trunk_path => string(0) ""
    branch_path => string(0) ""
    tag_path => string(0) ""
    ignore_paths => bool(false)

* The problem is that the URLs to Diff and File under Related Changeset in the Mantis issue view are not correct. The subpath name is repeated in the path part of the URL whilst this should not be the case.

    https://localhost/websvn/diff.php?repname=PROJECT1&rev=4030&path=/project1/trunk/code.txt&sc=1 [^]

    should be:

    https://localhost/websvn/diff.php?repname=PROJECT1&rev=4030&path=/trunk/code.txt&sc=1 [^]

The "path" part of the URL generated are not sensitive to modifications in websvn_path. The adjustment of the websvn_name only affects the "rename" part of the URL.

It looks like the "path" part of the URL comes from the svn repository URL and includes the full path from the repository root. Changing the the svn repository URL to file://localhost/var/www/svn/repos/ [^] gives the same result.

I looked into the php code but can not find an obvious place where things are going wrong. The websvn repository config data in MySQL matches the config above.

Any help would be greatly appreciated!

Best regards,
Rolf

Additional Information

Seen in Git master of Wed, 19 Jan 2011

Issue History
Date Modified	Username	Field	Change
2011-01-31 10:12	rolf	New Issue

Relationships

Notes
There are no notes attached to this issue.