062: Remove instances of pass-by-reference (deprecated in PHP 5.3.0)

Notice: this is a static mirror for historical purposes.

View Issue Details [ Jump to Notes ] [ Related Changesets ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

062

Source Integration

[All Projects] General

public

2009-09-22 07:41

2010-01-27 18:00

Reporter

David Hicks

Assigned To

John Reese

Priority

high

Severity

major

Reproducibility

always

Status

resolved

Resolution

fixed

Product Version

Target Version

0.14

Fixed in Version

0.14

Summary

062: Remove instances of pass-by-reference (deprecated in PHP 5.3.0)

Description

Passing by reference is not required in PHP because the interpreter uses copy-on-write. Additionally, as of PHP 5.3.0, passing by reference in functions is deprecated. See http://us2.php.net/manual/en/language.references.pass.php [^]

Matches with grep -RnP '&\$' *

plugins/Source/Source.FilterAPI.php:324: $s_permalink .= "&${p_string}[]=$t_value";
plugins/Source/Source.FilterAPI.php:337: $s_permalink .= "&$p_string=$t_input_clean";
plugins/Source/Source.API.php:129:function Source_Parse_Users( &$p_changeset ) {
plugins/Source/Source.API.php:1242: $t_versions = &$s_versions_sorted[ $t_project_id ][ $this->type ];

Tags

No tags attached.

Attached Files

Relationships

Notes
(084) John Reese (administrator) 2010-01-27 18:00	Fix committed to master branch at 2010-01-28 01:50:35.

Related Changesets
Source Integration: master 8b700544 Timestamp: 2010-01-28 01:50:35 Author: John Reese Committer: John Reese [ Details ] [ Diff ]	Fix 062: Remove pass-by-reference for PHP 5.3+
	mod - Source/Source.API.php	[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2009-09-22 07:41	David Hicks	New Issue
2009-10-18 16:43	John Reese	Status	new => acknowledged
2009-10-18 16:45	John Reese	Target Version	=> 0.16
2010-01-27 17:51	John Reese	Status	acknowledged => assigned
2010-01-27 17:51	John Reese	Assigned To	=> John Reese
2010-01-27 18:00	John Reese	Note Added: 084
2010-01-27 18:00	John Reese	Status	assigned => resolved
2010-01-27 18:00	John Reese	Fixed in Version	=> 0.16
2010-01-27 18:00	John Reese	Resolution	open => fixed
2010-01-27 18:00	John Reese	Changeset attached	master 8b700544 =>

Time: 0.1298 seconds.
memory usage: 8,327 KB

hosted with