Anonymous | Login | Signup for a new account | 2012-09-13 19:32 PDT |
Main | Blog | My View | View Issues | Change Log | Roadmap | IRC Chat | Repositories | Scrum Board |
View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||||
098 | Source Integration | WebSVN | public | 2010-02-16 20:42 | 2010-02-17 06:41 | ||||||
Reporter | James Keir | ||||||||||
Assigned To | |||||||||||
Priority | high | Severity | major | Reproducibility | always | ||||||
Status | new | Resolution | open | ||||||||
Product Version | 0.13 | ||||||||||
Target Version | Fixed in Version | ||||||||||
Summary | 098: Clicking Diff on the Changeset goes to wrong page in WebSVN 2.3.0 | ||||||||||
Description | When either on an issue (Related Changeset's) or browsing the repository when you click [Diff] for the changeset it directs you to websvn/listing.php where it should redirect to the websvn/comp.php. Currently you are just geting directed to the base of the repository with no diff. | ||||||||||
Tags | No tags attached. | ||||||||||
Attached Files | |||||||||||
![]() |
|
James Keir (reporter) 2010-02-17 06:41 edited on: 2010-02-18 13:12 |
I fix this by changing the following in "SourceWebSVN/SourceWebSVN.php" from: public function url_changeset( $p_repo, $p_changeset ) { return $this->url_repo( $p_repo, $p_changeset ); } To this: public function url_changeset( $p_repo, $p_changeset ) { $t_rev = ''; $t_rev_prev = ''; $t_path = ''; if ( !is_null( $p_changeset ) ) { $t_rev = urlencode( $p_changeset->revision ); $t_rev_prev = urlencode( $p_changeset->revision - 1 ); } return $p_repo->info['websvn_url'] . 'comp.php?repname=' . urlencode( $p_repo->info['websvn_name'] ) . "&compare[]=@" . $t_rev_prev . "&compare[]=@" . $t_rev; } Just thought I would include it, change it as you see fit. |
![]() |
|||
Date Modified | Username | Field | Change |
2010-02-16 20:42 | James Keir | New Issue | |
2010-02-17 06:41 | James Keir | Note Added: 095 | |
2010-02-18 13:12 | James Keir | Note Edited: 095 | View Revisions |
Copyright © 2000 - 2012 MantisBT Group
Time: 0.1483 seconds. memory usage: 8,315 KB |