| Anonymous | Login | Signup for a new account | 2010-09-06 09:04 EDT |
| Main | Blog | My View | View Issues | Change Log | Roadmap | Repositories |
| View Issue Details [ Jump to Notes ] [ Related Changesets ] | [ Issue History ] [ Print ] | |||||
| ID | Project | Category | View Status | Date Submitted | Last Update | |
| 039 | Source Integration | SFSVN | public | 2009-05-20 16:21 | 2009-06-08 09:40 | |
| Reporter | Alessandro Ren | |||||
| Assigned To | John Reese | |||||
| Priority | normal | Severity | major | Reproducibility | always | |
| Status | resolved | Resolution | fixed | |||
| Product Version | 0.13 | |||||
| Target Version | 0.14 | Fixed in Version | 0.14 | |||
| Summary | 039: Function load_by_name mixes repositories with similar names. | |||||
| Description | The load_by_name can return the wrong ID if repostiores have similar name like, nagios and nagios-plugins because of the SELECT using LIKE. | |||||
| Additional Information | I´ve change the query to use = (equal) and its working all right. //$t_query = "SELECT * FROM $t_repo_table WHERE name LIKE " . db_param(); $t_query = "SELECT * FROM $t_repo_table WHERE name = " . db_param(); //$t_result = db_query_bound( $t_query, array( '%' . $p_repo_name . '%' ) ); $t_result = db_query_bound( $t_query, array($p_repo_name) ); | |||||
| Tags | No tags attached. | |||||
| Attached Files | ||||||
Notes |
|
|
John Reese (administrator) 2009-06-08 09:40 |
Fix committed to master branch at 2009-06-08 13:34:39. |
Related Changesets |
|||
|
Source Integration: master c3261edf
Timestamp: 2009-06-08 13:34:39 Author: John Reese Committer: John Reese [ Details ] [ Diff ] |
Fix 039: Look for exact repository name before using wildcards. This modifies SourceRepo::load_by_name() to look for a repositoyr with the exact name given first, and then fallback onto the old method of looking for a repo that simply contains the given name. This both addresses the problem and maintains compatibility with the existing behavior and/or expectations. |
||
| mod - Source/Source.API.php | [ Diff ] [ File ] | ||
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2009-05-20 16:21 | Alessandro Ren | New Issue | |
| 2009-06-08 09:30 | John Reese | Assigned To | => John Reese |
| 2009-06-08 09:30 | John Reese | Status | new => assigned |
| 2009-06-08 09:30 | John Reese | Target Version | => 0.X |
| 2009-06-08 09:30 | John Reese | Description Updated | View Revisions |
| 2009-06-08 09:40 | John Reese | Note Added: 026 | |
| 2009-06-08 09:40 | John Reese | Status | assigned => resolved |
| 2009-06-08 09:40 | John Reese | Fixed in Version | => 0.X |
| 2009-06-08 09:40 | John Reese | Resolution | open => fixed |
| 2009-06-08 09:40 | John Reese | Changeset attached | master c3261edf => |
| Copyright © 2000 - 2010 MantisBT Group
Time: 0.0562 seconds. memory usage: 1,902 KB |